Lior Vernia has posted comments on this change. Change subject: webadmin : Removing instead of hiding virt-related fields in the host->general sub-tab ......................................................................
Patch Set 17: Code-Review+1 (1 comment) Fine by me as long as the commit message title is shortened a little. Kanagaraj, in Gluster-only mode the columns would look kinda weird, as there would be only 3 values in the first column, but 5 in the other two. 5-4-4 would be nicer than 3-5-5 in my opinion, but then all the CPU parameters won't be grouped together in the second column. I don't think any of these considerations is really important, but I'm giving you the last word on it :) .................................................... Commit Message Line 3: AuthorDate: 2013-10-28 13:47:28 +0530 Line 4: Commit: Anmol Babu <[email protected]> Line 5: CommitDate: 2013-11-07 19:29:10 +0530 Line 6: Line 7: webadmin : Removing instead of hiding virt-related fields in the host->general sub-tab Not shortened to ~50 characters. Line 8: Line 9: Removing instead of hiding virt-related fields in the host -> general Line 10: sub-tab and hence fix the allignment issues Line 11: -- To view, visit http://gerrit.ovirt.org/20603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8023616e95d2b52a0c4f813037df1e7f10e6083f Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
