Ravi Nori has posted comments on this change. Change subject: engine : Remove GetAllServerCpuListParameters class ......................................................................
Patch Set 12: (1 comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/GenericVdcParameter.java Line 3 Line 4 Line 5 Line 6 Line 7 My plan was to use 00000000-0000-0000-0000-000000000001 for first parameter in GenericVdcParameters. For each subsequent parameter added to GenericVdcParameters we increament th elast digit by 1. So second would be 00000000-0000-0000-0000-000000000002 and so on. Now when we add a new Parameter class like VmVdcParameter the first guid would be 20000000-0000-0000-0000-000000000001 and second would be 20000000-0000-0000-0000-000000000002. Every new parameter class we add for each group to maintain could have a different prefix and start off with 1 at the end. -- To view, visit http://gerrit.ovirt.org/20416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifedb114e8a2294bb3868077c0d3466557b1b8d45 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
