Alon Bar-Lev has posted comments on this change. Change subject: engine : Remove GetAllServerCpuListParameters class ......................................................................
Patch Set 12: (1 comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/GenericVdcParameter.java Line 3 Line 4 Line 5 Line 6 Line 7 uuidgen -r will do this work without having any need to sync between classes nor keep order, this is why uuid is chosen and not, for example, two integers. we need a method in which people can move parameter from one class to another, reorder, remove parameters (including last), adding new at the middle or in different classes, without conflict nor break some logic of ordering and allocation. -- To view, visit http://gerrit.ovirt.org/20416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifedb114e8a2294bb3868077c0d3466557b1b8d45 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
