Kanagaraj M has posted comments on this change.
Change subject: webadmin : remove-brick status error handling
......................................................................
Patch Set 5:
(3 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/RemoveBrickStatusModel.java
Line 81: GlusterVolumeTaskStatusEntity statusEntity =
vdcValue.getReturnValue();
Line 82: if (statusEntity != null) {
Line 83: showStatus(statusEntity);
Line 84: } else {
Line 85: cancelRefresh();
you should not cancelRefresh if the query is failed
Line 86: }
Line 87: }
Line 88: }), volumeEntity.getClusterId(), volumeEntity.getId(),
getBricks());
Line 89: }
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java
Line 953: }
Line 954: }
Line 955:
Line 956: final ConfirmationModel cModel = new ConfirmationModel();
Line 957: UICommand removeBrickStatusOk = new
UICommand("removeBrickNotAvailable", VolumeBrickListModel.this);//$NON-NLS-1$
change to "CancelRemoveBrickStatusNotAvailable"
Line 958:
removeBrickStatusOk.setTitle(ConstantsManager.getInstance().getConstants().ok());
Line 959: removeBrickStatusOk.setIsCancel(true);
Line 960:
Line 961:
cModel.startProgress(ConstantsManager.getInstance().getConstants().rebalanceStatusFetchMessage());
Line 1000:
cancelCommand.setTitle(ConstantsManager.getInstance().getConstants().close());
Line 1001: cancelCommand.setIsCancel(true);
Line 1002:
removeBrickStatusModel.getCommands().add(cancelCommand);
Line 1003:
Line 1004:
removeBrickStatusModel.showStatus(removeBrickStatusEntity);
why do you need to move this inside this block?
Line 1005:
Line 1006: } else {
Line 1007:
cModel.setMessage(ConstantsManager.getInstance().getMessages().removeBrickStatusFailed(bricks.toString()));
Line 1008: }
--
To view, visit http://gerrit.ovirt.org/21086
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57bb82ebc0318266f32262c6f9bb245e26f2ddd1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
