Kanagaraj M has posted comments on this change.
Change subject: webadmin : remove-brick status error handling
......................................................................
Patch Set 7:
(3 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java
Line 992: public void onSuccess(Object model, Object returnValue) {
Line 993:
Line 994: cModel.stopProgress();
Line 995: VdcQueryReturnValue vdcValue = (VdcQueryReturnValue)
returnValue;
Line 996: if (vdcValue.getSucceeded() ||
vdcValue.getReturnValue() != null) {
it should be vdcValue.getSucceeded() && vdcValue.getReturnValue() != null
Line 997: cancelConfirmation();
Line 998: RemoveBrickStatusModel removeBrickStatusModel =
new RemoveBrickStatusModel(volumeEntity, bricks);
Line 999:
removeBrickStatusModel.setTitle(ConstantsManager.getInstance().getConstants().removeBricksStatusTitle());
Line 1000: setWindow(removeBrickStatusModel);
Line 1015:
removeBrickStatusModel.showStatus(removeBrickStatusEntity);
Line 1016:
Line 1017: } else {
Line 1018:
cModel.setMessage(ConstantsManager.getInstance().getMessages().removeBrickStatusFailed(bricks.toString()));
Line 1019: }
how does it work if the user is clicking 'Stop' in the remove-brick status
dialog?
Line 1020: }
Line 1021: }),
Line 1022: volumeEntity.getClusterId(),
Line 1023: volumeEntity.getId(),
Line 1307: onAddBricksInternal();
Line 1308: } else if (command.getName().equals("CancelConfirmation")) {
//$NON-NLS-1$
Line 1309: cancelConfirmation();
Line 1310: }else
if(command.getName().equals("CancelRemoveBrickStatusNotAvailable")){//$NON-NLS-1$
Line 1311: setConfirmWindow(null);
CancelConfirmation can be re-used here
Line 1312: } else if (command.equals(getRemoveBricksCommand())) {
Line 1313: removeBricks();
Line 1314: } else if (command.getName().equals("OnRemove")) {
//$NON-NLS-1$
Line 1315: onRemoveBricks();
--
To view, visit http://gerrit.ovirt.org/21086
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57bb82ebc0318266f32262c6f9bb245e26f2ddd1
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
