Alon Bar-Lev has posted comments on this change.
Change subject: engine : Change parameter type of CommandBase
......................................................................
Patch Set 1:
(2 comments)
Great!
I am not sure I understand.... maybe there is some limitation... and we discuss
that.
1. I suggest a type of CommandList and QueryList so that we do not care what
the type of parameters, will will make this change or any other change clearer.
2. Isn't it an option that in these case of generic handling commands we use
the new VdcParametersMap mechanism? And leave the legacy functions within the
VdcActionParametersBase?
I want to make sure that converted commands are not using the legacy
interfaces, and by moving the methods of VdcACtionParametersBase into the map
this is impossible now.
Thanks!
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1668: /** @return The type of task that should be created for this
command. Commands that do not create async tasks should throw a {@link
UnsupportedOperationException} */
Line 1669: private AsyncTaskType internalGetTaskType() {
Line 1670: if (hasTaskHandlers()) {
Line 1671: System.out.println("has task handlers");
Line 1672: System.out.println("getParameters().getExecutionReason()
"+getParameters().getExecutionReason());
log?
Line 1673: if (getParameters().getExecutionReason() ==
CommandExecutionReason.REGULAR_FLOW) {
Line 1674: return getCurrentTaskHandler().getTaskType();
Line 1675: }
Line 1676: return getCurrentTaskHandler().getRevertTaskType();
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
Line 691: if (!messages.isEmpty()) {
Line 692: VdcReturnValueBase returnErrorValue = new
VdcReturnValueBase();
Line 693: returnErrorValue.setCanDoAction(false);
Line 694:
returnErrorValue.getCanDoActionMessages().addAll(messages);
Line 695: System.out.println("returnErrorValue = "+
returnErrorValue);
log?
Line 696: return returnErrorValue;
Line 697: }
Line 698: }
Line 699: System.out.println("returnValue = "+ returnValue);
--
To view, visit http://gerrit.ovirt.org/21319
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c702d8f4184f08690d38902593bb4b733c69d95
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
