Alon Bar-Lev has posted comments on this change.
Change subject: engine : Change parameter type of CommandBase
......................................................................
Patch Set 2:
(3 comments)
BEAUTIFUL!!!!
Now if we rebase the patches that removes the usage of the parameters classes
we should end up with clean code, right?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandAsyncTask.java
Line 125: }
Line 126: }
Line 127:
Line 128: return childrenTasksSuccess;
Line 129: }
duplicate of commandbase? can't we reuse logic?
Line 130:
Line 131: private void EndCommandAction() {
Line 132: CommandMultiAsyncTasks entityInfo =
GetCommandMultiAsyncTasks();
Line 133: VdcReturnValueBase vdcReturnValue = null;
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 173: String sessionid =
getParameters().<String>get(CoreVdcParameters.SESSION_ID);
Line 174: if (sessionid == null) {
Line 175: sessionid = "";
Line 176: }
Line 177: return sessionid;
won't it better to accept session id null instead of "" all over?
Line 178: }
Line 179:
Line 180: protected CommandBase(T parameters) {
Line 181: _parameters = parameters;
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
Line 702: }
Line 703: return returnValue;
Line 704: }
Line 705:
Line 706: static class EvalCorrelationId {
private? why static?
Line 707:
Line 708: /**
Line 709: * A cross system identifier of the executed action
Line 710: */
--
To view, visit http://gerrit.ovirt.org/21319
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c702d8f4184f08690d38902593bb4b733c69d95
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
