Kanagaraj M has posted comments on this change. Change subject: webadmin: Gluster Create Volume dialog changes ......................................................................
Patch Set 1: (5 inline comments) responses to inline comments. .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java Line 17: getReplicaCount().setEntity(2); ok. Is there a constants where i can add it? or to this class itself. .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java Line 132: yes i will remove. Line 135: getAddBricksCommand().Execute(); Yes. As most of the times changing type leads to re-selection of bricks. But the popup will not opened when we select the type in the code(defaults to DISTRIPUTE). .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java Line 283: volume.setStripeCount(Integer.parseInt((String) model.getStripeCount().getEntity())); I am not sure. But the EntityModelTextBoxEditor sets it as String. Is there a generics support? .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.java Line 98: table.setRowData(new ArrayList<ListModel>()); It is there in AbstractPermissionsPopupView which i have referred, I will remove that. -- To view, visit http://gerrit.ovirt.org/3899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61163b772c97f70ab055583efd54bc8bfbaafe04 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
