Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Gluster Create Volume dialog changes
......................................................................
Patch Set 3: Verified; Looks good to me, approved
1) volume type enum - please translate.
e.g. (maybe) DISTRIBUTED_REPLICATE = Distributed & Replicate ?
2) localization: you use ignore strings (//$NON-NLS-1$) in places that you
shouldn't, it should be localized, please check it out.
(e.g. innerVolumeModel.getDataCenter().setInfo("Cannot choose Volume's Data
Center in tree context"); //$NON-NLS-1$)
I'm merging your patches anyhow.
Please change it later.
--
To view, visit http://gerrit.ovirt.org/3899
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61163b772c97f70ab055583efd54bc8bfbaafe04
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
