Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Refactored rebalance/remove-brick status queries ......................................................................
Patch Set 1: (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRemoveBricksStatusQuery.java Line 21: getParameters().getBricks(), Line 22: volume.getReplicaCount())); Line 23: Line 24: // Set the volume remove bricks start time Line 25: GlusterVolumeTaskStatusEntity entity = setStartTime((GlusterVolumeTaskStatusEntity) returnValue.getReturnValue()); There is not difference. Only the null checks were done in two steps in rebalance case which is performed as part of one if condition here. Line 26: Line 27: // Set the host ip in status details Line 28: updateHostIP(entity); Line 29: -- To view, visit http://gerrit.ovirt.org/21448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31f7d438641ad05874542fd57b723a0d482a68e4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
