Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: Refactored rebalance/remove-brick status queries
......................................................................
Patch Set 3: -Verified
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncTaskStatusQueryBase.java
Line 34: }
Line 35: }
Line 36:
Line 37: if (clusterId == null) {
Line 38: clusterId = volume.getClusterId();
Once the control reaches here, its sure that volume is not null, because in
case volume is null there is an exception thrown above already.
So null check not required here.
Line 39: }
Line 40:
Line 41: getQueryReturnValue().setReturnValue(fetchTaskStatusDetails());
Line 42: }
--
To view, visit http://gerrit.ovirt.org/21448
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31f7d438641ad05874542fd57b723a0d482a68e4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
