Piotr Kliczewski has posted comments on this change. Change subject: utils: ssh: force close the pipe before the layered stream ......................................................................
Patch Set 1: I do not know anyone who did not close streams pre java 7. It is very bad practice and after few hrs of running such code will run out of resources. Try-with-resources is just syntactic sugar and compiler generated exactly the same byte code as you would write close stream in finally block. You can verify that quite easily. >From my perspective there is 1 of two issues: 1. The stream was closed by loosing connectivity (maybe network reconfiguration) and we do not check the state of the connection. 2. Try-with resources is buggy and we need to open java bug. -- To view, visit http://gerrit.ovirt.org/21460 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I485f5ae57a963b6819fdc0f3832eaa403dc0c34d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
