Alon Bar-Lev has posted comments on this change.

Change subject: utils: ssh: force close the pipe before the layered stream
......................................................................


Patch Set 1:

> It is not complete void. You changed the order by adding additional try block 
> which is not needed. Single try block and having pouts last will do the trick.

I do not understand... I did not change the order in this patch. See that the 
close order is exactly the same as far as pipe and layered stream is involved.

In both cases, first the pipe is closed then the layered stream is closed.

So I do not understand why the original error you reported is now gone.

-- 
To view, visit http://gerrit.ovirt.org/21460
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I485f5ae57a963b6819fdc0f3832eaa403dc0c34d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to