Allon Mureinik has posted comments on this change.
Change subject: core: Prevent usage of shareable disks on Gluster domains
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
@Cheryn, please take a look at the new message added to
backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Thanks!
@Tal:
1. There an NPE in AddDiskCommand - see inline
2. IIUC, you're missing a new constant in
./frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 85: }
Line 86:
Line 87: if (getParameters().getDiskInfo().isShareable() &&
getStorageDomain().getStorageType() == StorageType.GLUSTERFS) {
Line 88: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_SHAREABLE_DISKS_NOT_SUPPORTED_ON_GLUSTER_DOMAIN);
Line 89: }
This should be done inside checkIfImageDiskCanBeAdded(VM).
If the disk is a direct LUN, getStorageDomain().getStorageType() will thrown an
NPE.
Line 90:
Line 91: VM vm = getVm();
Line 92:
Line 93: if (vm != null) {
--
To view, visit http://gerrit.ovirt.org/21585
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d741c93d32fa568c1d1f10429cb325a9b01c359
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Cheryn Tan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
