Liron Ar has posted comments on this change. Change subject: core: Prevent usage of shareable disks on Gluster domains ......................................................................
Patch Set 5: (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java Line 152: Line 153: // vm agnostic checks Line 154: returnValue = Line 155: validate(new StorageDomainValidator(getStorageDomain()).isDomainExistAndActive()) && Line 156: checkImageConfiguration() && please move this check here (Before the image configuration), there's no need to perform all of it if it isn't relevant.. (for example, why do we need a message about space in the domain if we can't even add it?) it will also reduce the query count here. Line 157: hasFreeSpace(getStorageDomain()) && Line 158: checkExceedingMaxBlockDiskSize() && Line 159: canAddShareableDisk() && Line 160: validate(diskValidator.isVirtIoScsiValid(vm)); -- To view, visit http://gerrit.ovirt.org/21585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d741c93d32fa568c1d1f10429cb325a9b01c359 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Cheryn Tan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
