Alissa Bonas has posted comments on this change. Change subject: core: Remove unused XmlDocument.nameTable ......................................................................
Patch Set 1: (1 comment) .................................................... Commit Message Line 9: XmlDocument.nameTable is never initialized and therefore is always null. Line 10: Since it holds no data, it can safely be removed. Line 11: Line 12: The only place this field was ever referenced was by calls to new Line 13: XmlNamspaceManager(Object), which simply ignored the passed object. XmlNamspace-->XmlNamespace Line 14: Since this parameter is not used anyway, and is always called with Line 15: XmlDocument.nameTable, the constructor was changed and the parameter was Line 16: removed. Line 17: -- To view, visit http://gerrit.ovirt.org/21600 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie922fdd01d85a6f61fadaccd2a20263c7d013f85 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
