Roy Golan has submitted this change and it was merged. Change subject: core: Remove unused XmlDocument.nameTable ......................................................................
core: Remove unused XmlDocument.nameTable XmlDocument.nameTable is never initialized and therefore is always null. Since it holds no data, it can safely be removed. The only place this field was ever referenced was by calls to new XmlNamespaceManager(Object), which simply ignored the passed object. Since this parameter is not used anyway, and is always called with XmlDocument.nameTable, the constructor was changed and the parameter was removed. Change-Id: Ie922fdd01d85a6f61fadaccd2a20263c7d013f85 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlDocument.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlNamespaceManager.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfParser.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 4 files changed, 3 insertions(+), 4 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21600 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie922fdd01d85a6f61fadaccd2a20263c7d013f85 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
