Alissa Bonas has uploaded a new change for review. Change subject: engine: rename member to lowercase in BaseConditionFieldAutoCompleter. ......................................................................
engine: rename member to lowercase in BaseConditionFieldAutoCompleter. Rename to start with lowercase, fixes a findbug warning. Change-Id: I57c4ff1796b595e10b225c6bf7b58067dbd242b5 Signed-off-by: Alissa Bonas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java 2 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/36/21636/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java index 2862d02..d9ac91d 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java @@ -105,7 +105,7 @@ private void initHandlers() { mTagsHandler = HandlersFactory.createTagsHandler(); - BaseConditionFieldAutoCompleter.TagsHandler = mTagsHandler; + BaseConditionFieldAutoCompleter.tagsHandler = mTagsHandler; VmHandler.init(); VdsHandler.Init(); VmTemplateHandler.Init(); diff --git a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java index 49ea94d..ed393fe 100644 --- a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java +++ b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java @@ -65,7 +65,7 @@ } - public static ITagsHandler TagsHandler = null; + public static ITagsHandler tagsHandler = null; public Map<String, Class<?>> getTypeDictionary() { return typeDict; @@ -316,10 +316,10 @@ if (pair.getFirst() != null && pair.getFirst().equals("=")) { pair.setFirst("IN"); pair.setSecond(StringHelper.trim(pair.getSecond(), '\'')); - tags tag = TagsHandler.GetTagByTagName(pair.getSecond()); + tags tag = tagsHandler.GetTagByTagName(pair.getSecond()); if (tag != null) { pair.setSecond( - StringFormat.format("(%1$s)", TagsHandler.GetTagNameAndChildrenNames(tag.gettag_id()))); + StringFormat.format("(%1$s)", tagsHandler.GetTagNameAndChildrenNames(tag.gettag_id()))); } else { pair.setSecond(StringFormat.format("('%1$s')", Guid.Empty)); } @@ -327,7 +327,7 @@ pair.setFirst("IN"); pair.setSecond(StringHelper.trim(pair.getSecond(), '\'').replace("%", "*")); - String IDs = TagsHandler.GetTagNamesAndChildrenNamesByRegExp(pair.getSecond()); + String IDs = tagsHandler.GetTagNamesAndChildrenNamesByRegExp(pair.getSecond()); if (StringHelper.isNullOrEmpty(IDs)) { pair.setSecond(StringFormat.format("('%1$s')", Guid.Empty)); } else { -- To view, visit http://gerrit.ovirt.org/21636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I57c4ff1796b595e10b225c6bf7b58067dbd242b5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
