Alissa Bonas has uploaded a new change for review. Change subject: frontend: prevent unboxing of integer in AsyncDataProvider ......................................................................
frontend: prevent unboxing of integer in AsyncDataProvider It solves 2 findbugs warnings of type BX_UNBOXING_IMMEDIATELY_REBOXED Change-Id: I8c673f3afddb48b9982d3448f3603002e7a8cf6f Signed-off-by: Alissa Bonas <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/35/21635/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java index f15dbf7..e3c42c8 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java @@ -3420,11 +3420,17 @@ public static Integer getMaxVmNameLengthWin() { Integer maxVmNameLengthWindows = (Integer) AsyncDataProvider.getConfigValuePreConverted(ConfigurationValues.MaxVmNameLengthWindows); - return maxVmNameLengthWindows == null ? 15 : maxVmNameLengthWindows; + if(maxVmNameLengthWindows == null) { + return 15; + } + return maxVmNameLengthWindows; } public static Integer getMaxVmNameLengthNonWin() { Integer maxVmNameLengthNonWindows = (Integer) AsyncDataProvider.getConfigValuePreConverted(ConfigurationValues.MaxVmNameLengthNonWindows); - return maxVmNameLengthNonWindows == null ? 64 : maxVmNameLengthNonWindows; + if(maxVmNameLengthNonWindows == null) { + return 64; + } + return maxVmNameLengthNonWindows; } } -- To view, visit http://gerrit.ovirt.org/21635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8c673f3afddb48b9982d3448f3603002e7a8cf6f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
