Allon Mureinik has posted comments on this change.
Change subject: engine: Populate error message placeholder in
HotPlugDiskToVmCommand
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java
Line 37: protected void setActionMessageParameters() {
Line 38: addCanDoActionMessage(VdcBllMessages.VAR__ACTION__HOT_PLUG);
Line 39: addCanDoActionMessage(VdcBllMessages.VAR__TYPE__VM_DISK);
Line 40:
Line 41: if (getDiskAlias() != null) {
IIUC, getDiskAlias() can never be null.
Either there is such a disk (in which case it MUST have an alias), or there
isn't, in which can getDiskAlias() will throw a NullPointerException.
Did you perhaps mean to check
if (getDisk() != null) ?
Line 42: addCanDoActionMessage(String.format("$%1$s %2$s",
"diskAliases", getDiskAlias()));
Line 43: }
Line 44: }
Line 45:
--
To view, visit http://gerrit.ovirt.org/21800
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff5224477b8ba547ea7dcde9069ec8874fa8ed24
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
