Liron Ar has posted comments on this change.
Change subject: engine: Populate error message placeholder in
HotPlugDiskToVmCommand
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Marking -1 till my comment is answered because this has +2 already.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java
Line 39: addCanDoActionMessage(VdcBllMessages.VAR__TYPE__VM_DISK);
Line 40:
Line 41: if (getDisk() != null) {
Line 42: addCanDoActionMessage(String.format("$%1$s %2$s",
"diskAliases", getDiskAlias()));
Line 43: }
imo this should be added only when it's needed by the message,
theres no need to add the disk alias if we get a message that the vm isn't down
for example..as we do for all the messages.
Line 44: }
Line 45:
Line 46: @Override
Line 47: protected boolean canDoAction() {
--
To view, visit http://gerrit.ovirt.org/21800
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff5224477b8ba547ea7dcde9069ec8874fa8ed24
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
