Daniel Erez has posted comments on this change.

Change subject: webadmin: Add icons to bootable and shareable columns
......................................................................


Patch Set 1:

(1 comment)

....................................................
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java
Line 400:                 
AbstractImagePrototype.create(resources.readOnlyDiskIcon()).getHTML()), 
constants.readOnly()
Line 401:         );
Line 402:         
internalDiskTable.addColumn(DisksViewColumns.readOnlyCheckboxColumn, 
readOnlyColumnHeader, "30px"); //$NON-NLS-1$
Line 403: 
Line 404:         SafeHtml bootableColumnHeader = 
templates.imageWithTitle(SafeHtmlUtils.fromTrustedString(
please add these to the externalDiskTable as well
Line 405:                 
AbstractImagePrototype.create(resources.bootableDiskIcon()).getHTML()), 
constants.bootable()
Line 406:         );
Line 407:         internalDiskTable.addColumn(new 
ImageResourceColumn<EntityModel>() {
Line 408:             @Override


-- 
To view, visit http://gerrit.ovirt.org/21959
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I776739681d9ae47d6d7dc92115dc7269e2495127
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to