Daniel Erez has posted comments on this change.
Change subject: webadmin: Add icons to bootable and shareable columns
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java
Line 410: Disk disk = (((DiskModel)
(object.getEntity())).getDisk());
Line 411: setTitle(disk.isBoot() ? constants.bootableDisk() :
null);
Line 412: return disk.isBoot() ? resources.bootableDiskIcon() :
null;
Line 413: }
Line 414: }, bootableColumnHeader, "30px"); //$NON-NLS-1$ //$NON-NLS-2$
no need for the second //$NON-NLS
Line 415:
Line 416: SafeHtml shareableColumnHeader =
templates.imageWithTitle(SafeHtmlUtils.fromTrustedString(
Line 417:
AbstractImagePrototype.create(resources.shareableDiskIcon()).getHTML()),
constants.shareable()
Line 418: );
Line 422: Disk disk = (((DiskModel)
(object.getEntity())).getDisk());
Line 423: setTitle(disk.isShareable() ? constants.shareable() :
null);
Line 424: return disk.isShareable() ?
resources.shareableDiskIcon() : null;
Line 425: }
Line 426: }, shareableColumnHeader, "30px"); //$NON-NLS-1$ //$NON-NLS-2$
same
Line 427:
Line 428: internalDiskTable.setWidth("100%", true); //$NON-NLS-1$
Line 429: internalDiskTable.setHeight("100%"); //$NON-NLS-1$
Line 430: }
--
To view, visit http://gerrit.ovirt.org/21959
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I776739681d9ae47d6d7dc92115dc7269e2495127
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
