Yair Zaslavsky has posted comments on this change.

Change subject: engine: Move anonymousHugePage to VdsStatistics
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

I would like Eli and Omer to take a look, technically looks ok to me.

....................................................
File packaging/dbscripts/upgrade/03_04_0160_move_anonymousHugePages.sql
Line 1: CREATE OR REPLACE FUNCTION __temp_move_anonymousHugePages() RETURNS void
Line 2: AS $FUNCTION$
Line 3: BEGIN
Line 4:   IF (NOT EXISTS (SELECT 1 FROM information_schema.columns WHERE 
table_name ILIKE 'vds_statistics' AND column_name ILIKE 'anonymous_hugepages')) 
THEN
Line 5:     -- add quota id column to the image-storage map table
comments are incorrect - probably copy/paste error.
Line 6:     PERFORM fn_db_add_column('vds_statistics','anonymous_hugepages', 
'INTEGER NULL');
Line 7:     -- copy old quota from images table
Line 8:     UPDATE vds_statistics vs SET anonymous_hugepages = (SELECT 
anonymous_hugepages FROM vds_dynamic vd WHERE vs.vds_id = vd.vds_id);
Line 9:     -- remove quota_id column from images table


-- 
To view, visit http://gerrit.ovirt.org/21934
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20dba0ba8beaac916f8af5f49456593077176efa
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to