Liron Ar has posted comments on this change.
Change subject: engine: Move anonymousHugePage to VdsStatistics
......................................................................
Patch Set 4:
(1 comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java
Line 103: && ObjectUtils.objectsEqual(ksm_cpu_percent,
other.ksm_cpu_percent)
Line 104: && ObjectUtils.objectsEqual(swap_total,
other.swap_total)
Line 105: && ObjectUtils.objectsEqual(swap_free,
other.swap_free)
Line 106: && ObjectUtils.objectsEqual(highlyAvailableScore,
other.highlyAvailableScore)
Line 107: && ObjectUtils.objectsEqual(anonymousHugePages,
other.anonymousHugePages));
it's primitive int, no need to use objectsEquals which will cause to unneeded
boxing
Line 108: }
Line 109:
Line 110: public Double getcpu_idle() {
Line 111: return this.cpu_idle.doubleValue();
--
To view, visit http://gerrit.ovirt.org/21934
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20dba0ba8beaac916f8af5f49456593077176efa
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
