Vojtech Szocs has posted comments on this change.

Change subject: webadmin: manage cluster networks dialog
......................................................................


Patch Set 10:

New patch set ready for review, with following changes:

- Since updating network's "required" and "display" flags is now done via the 
attach action (AttachNetworkToVdsGroup), "required" column is enabled for 
editing only when the network is attached, just like "display" column.

- For existing cluster network, if the user changed "required" or "display" 
flag through the dialog, update that network via the attach action. In case the 
network needs to be detached, don't update it.

This means, updating "required" or "display" flags has effect only for:
a) networks that need to be attached to cluster
b) networks that are currently attached and don't need to be detached from 
cluster

--
To view, visit http://gerrit.ovirt.org/3209
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I617a73105dcadd6733b4a854ebdece47b066d367
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Danny Rankevich <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Danny Rankevich <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to