Vojtech Szocs has posted comments on this change. Change subject: webadmin: manage cluster networks dialog ......................................................................
Patch Set 11: Rebased new version of this patch (no changes since last time). Verified that both "display" and "required" attributes are now updated through network attach action. Roy, I've tried to play with the dialog but couldn't reproduce the "network shown twice" issue.. I've tried following steps: 1. DataCenters > LogicalNetworks: create new network, without assigning it to any clusters 2. Clusters > LogicalNetworks: open manage network dialog, mark new network as attached and click OK (no duplicities in sub-tab network table nor dialog network table) 1. detach network(s) from cluster via manage network dialog 2. attach these network(s) again via manage network dialog (again, no duplicities in both tables) How can I reproduce the "network shown twice" issue? :-) -- To view, visit http://gerrit.ovirt.org/3209 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I617a73105dcadd6733b4a854ebdece47b066d367 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Danny Rankevich <danny....@gmail.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Danny Rankevich <danny....@gmail.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches