Eli Mesika has posted comments on this change. Change subject: core: Mark management network as display and migration ......................................................................
Patch Set 1: Code-Review-1 (1 comment) .................................................... File packaging/dbscripts/upgrade/03_04_0240_set_display_migration_cluster_network.sql Line 5: id UUID; Line 6: BEGIN Line 7: SELECT option_value FROM vdc_options WHERE option_name='ManagementNetwork' INTO mgmt_name; Line 8: FOR id IN (SELECT DISTINCT cluster_id FROM network_cluster) LOOP Line 9: SELECT network_id FROM network_cluster_view WHERE cluster_id=id AND network_name=mgmt_name INTO mgmt_id; No, views are not supposed to exists during the upgrade script since the upgrade may change the underlying tables on which the view is based Please pass by and we will think together on an alternative approach for achieving that Line 10: IF NOT EXISTS (SELECT 1 FROM network_cluster WHERE cluster_id=id AND is_display=true) THEN Line 11: UPDATE network_cluster SET is_display=true WHERE cluster_id=id AND network_id=mgmt_id; Line 12: END IF; Line 13: IF NOT EXISTS (SELECT network_id FROM network_cluster WHERE cluster_id=id AND migration=true) THEN -- To view, visit http://gerrit.ovirt.org/22382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73bf3c583ae28bf32d7c602ec9f4b0fb5c7f391d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
