Eli Mesika has posted comments on this change. Change subject: core: Mark management network as display and migration ......................................................................
Patch Set 4: Code-Review-1 (4 comments) .................................................... File packaging/dbscripts/upgrade/03_04_0240_set_display_migration_cluster_network.sql Line 1: CREATE FUNCTION _set_display_migration() RETURNS VOID AS $$ function name should be prefixed by __temp_ to prevent any chance of dropping valid functions Line 2: DECLARE Line 3: mgmt_name CHARACTER VARYING(15); Line 4: mgmt_id UUID; Line 5: id UUID; Line 8: FROM vdc_options Line 9: WHERE option_name='ManagementNetwork' Line 10: INTO mgmt_name; Line 11: Line 12: CREATE TEMP TABLE mgmt_table ( Please avoid using temp tables This query should be executed by using a CURSOR on SELECT network_id FROM mgmt_table 27 WHERE cluster_id=id and doing the logic for each retrieved row of this query see example for CURSOR usage in 03_01_0740_add_vm_device_soundcard.sql Line 13: cluster_id UUID, Line 14: network_id UUID Line 15: ); Line 16: Line 46: END LOOP; Line 47: END; Line 48: $$ LANGUAGE plpgsql; Line 49: Line 50: SELECT _set_display_migration(); same Line 51: Line 48: $$ LANGUAGE plpgsql; Line 49: Line 50: SELECT _set_display_migration(); Line 51: Line 52: DROP FUNCTION _set_display_migration(); same -- To view, visit http://gerrit.ovirt.org/22382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73bf3c583ae28bf32d7c602ec9f4b0fb5c7f391d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
