Yedidyah Bar David has uploaded a new change for review. Change subject: core: Alert on log file opening failure ......................................................................
core: Alert on log file opening failure Change-Id: If1da48cc50985a3d353964466f38babbbd42f4f3 Signed-off-by: Yedidyah Bar David <[email protected]> --- M src/otopi/main.py M src/plugins/otopi/core/log.py 2 files changed, 22 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/otopi refs/changes/25/22625/1 diff --git a/src/otopi/main.py b/src/otopi/main.py index 9544317..bd5e13b 100644 --- a/src/otopi/main.py +++ b/src/otopi/main.py @@ -25,6 +25,7 @@ import os import signal import logging +import traceback import gettext _ = lambda m: gettext.dgettext(message=m, domain='otopi') @@ -77,11 +78,13 @@ logging.Handler.__init__(self) def emit(self, record): - pass + print record + print "Start of _setupLogger" + traceback.print_stack() logger = logging.getLogger(constants.Log.LOGGER_BASE) logger.propagate = False - logger.setLevel(logging.DEBUG) + logger.setLevel(logging.WARNING) logger.addHandler(NullHandler()) def _setupGettext(self): diff --git a/src/plugins/otopi/core/log.py b/src/plugins/otopi/core/log.py index 8618931..9044077 100644 --- a/src/plugins/otopi/core/log.py +++ b/src/plugins/otopi/core/log.py @@ -142,11 +142,23 @@ # so when re-exec we use same log os.environ[constants.SystemEnvironment.LOG_FILE] = logFileName - self.environment[constants.CoreEnv.LOG_FILE_HANDLE] = open( - self.resolveFile(logFileName), - mode='a', - buffering=1 - ) + try: + self.environment[constants.CoreEnv.LOG_FILE_HANDLE] = open( + self.resolveFile(logFileName), + mode='a', + buffering=1 + ) + except IOError as e: + raise RuntimeError( + _( + 'Error opening log file {file}: {error}' + ).format( + file=self.resolveFile(logFileName), + error=e, + ) + ) + + print "Opened log file ", logFileName self._handler = logging.StreamHandler( self.environment[constants.CoreEnv.LOG_FILE_HANDLE] ) -- To view, visit http://gerrit.ovirt.org/22625 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If1da48cc50985a3d353964466f38babbbd42f4f3 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
