Alon Bar-Lev has posted comments on this change.
Change subject: core: Alert on log file opening failure
......................................................................
Patch Set 3:
(1 comment)
....................................................
File src/otopi/context.py
Line 155: self.environment[constants.BaseEnv.ABORTED] = True
Line 156: self.logger.warning(_('Aborted'))
Line 157: else:
Line 158: print(
Line 159: _("***L:ERROR: Failed to execute stage '{stage}':
{exception}").format(
the ***:L:ERROR cannot be localized. also there are not ':' after.
This is not that good, as exceptions are written into the dialog.
You need only to print error regarding log if you like.
Otherwise you break the machine dialog once it is installed, as error will go
twice to stdout, once per print and once per self.logger.
Line 160: stage=plugin.Stages.stage_str(stage),
Line 161: exception=e,
Line 162: )
Line 163: )
--
To view, visit http://gerrit.ovirt.org/22625
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If1da48cc50985a3d353964466f38babbbd42f4f3
Gerrit-PatchSet: 3
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
