Moti Asayag has posted comments on this change. Change subject: engine: Add security groups support ......................................................................
Patch Set 1: (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/NetworkProviderProxy.java Line 37: * The vNIC to allocate. Line 38: * @return A map of custom properties to forward for the vNIC device. The correct driver will know how to handle Line 39: * these properties, and connect the vNIC correctly. Line 40: */ Line 41: Map<String, String> allocate(Network network, VnicProfile vnicProfile, VmNic nic); why do you need to pass the vnicProfile the entire way ? you have the profile id as part of the nic and you can retrieve it from the allocate impl and save this api change. Line 42: Line 43: /** Line 44: * Deallocate the vNIC from the provider. If the vNIC is not on the provider anymore, don't throw an exception. Line 45: * -- To view, visit http://gerrit.ovirt.org/22651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96faec7dee39045a8a39ce27351aac6b7eb20e23 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
