Mike Kolesnik has posted comments on this change.
Change subject: engine: Add security groups support
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/NetworkProviderProxy.java
Line 37: * The vNIC to allocate.
Line 38: * @return A map of custom properties to forward for the vNIC
device. The correct driver will know how to handle
Line 39: * these properties, and connect the vNIC correctly.
Line 40: */
Line 41: Map<String, String> allocate(Network network, VnicProfile
vnicProfile, VmNic nic);
Technically you're correct, however it's not the responsibility of the
implementer to retrieve the data from the DB, it should just communicate the
correct data to the provider.
Hence I prefer it would receive the necessary data from outside, and focus on
what it knows (talking to the provider).
Line 42:
Line 43: /**
Line 44: * Deallocate the vNIC from the provider. If the vNIC is not on
the provider anymore, don't throw an exception.
Line 45: *
....................................................
File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 617: select fn_db_add_config_value('CustomDeviceProperties', '', '3.0');
Line 618: select fn_db_add_config_value('CustomDeviceProperties', '', '3.1');
Line 619: select fn_db_add_config_value('CustomDeviceProperties', '', '3.2');
Line 620: select fn_db_add_config_value('CustomDeviceProperties', '', '3.3');
Line 621: select fn_db_add_config_value('CustomDeviceProperties',
'{type=interface;prop={security_groups=^(?:[0-9a-fA-F]{8}-(?:[0-9a-fA-F]{4}-){3}[0-9a-fA-F]{12},
*)*[0-9a-fA-F]{8}-(?:[0-9a-fA-F]{4}-){3}[0-9a-fA-F]{12}$}}', '3.4');
Done
Line 622:
Line 623: select fn_db_add_config_value('SshSoftFencingCommand', 'service vdsmd
restart', '3.0');
Line 624: select fn_db_add_config_value('SshSoftFencingCommand', 'service vdsmd
restart', '3.1');
Line 625: select fn_db_add_config_value('SshSoftFencingCommand', 'service vdsmd
restart', '3.2');
--
To view, visit http://gerrit.ovirt.org/22651
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I96faec7dee39045a8a39ce27351aac6b7eb20e23
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
