Alon Bar-Lev has posted comments on this change.
Change subject: Change versioning schema and fix tarball
......................................................................
Patch Set 6:
(4 comments)
....................................................
File mom.spec.in
Line 56: make %{?_smp_mflags}
Line 57:
Line 58: %install
Line 59: rm -rf "%{buildroot}"
Line 60: %{__python} setup.py install -O1 --skip-build --root "%{buildroot}"
why do you use the setup? the make install should be sufficient, do not mix
build systems, either you use the setuptools or autotools.
Line 61: install -Dp contrib/momd.init "%{buildroot}"/%{_initrddir}/momd
Line 62:
Line 63: cp
"%{buildroot}"/%{_defaultdocdir}/%{name}/examples/mom-balloon+ksm.conf \
Line 64: "%{buildroot}"/%{_sysconfdir}/momd.conf
Line 57:
Line 58: %install
Line 59: rm -rf "%{buildroot}"
Line 60: %{__python} setup.py install -O1 --skip-build --root "%{buildroot}"
Line 61: install -Dp contrib/momd.init "%{buildroot}"/%{_initrddir}/momd
you should support both systemd and sysv.
Line 62:
Line 63: cp
"%{buildroot}"/%{_defaultdocdir}/%{name}/examples/mom-balloon+ksm.conf \
Line 64: "%{buildroot}"/%{_sysconfdir}/momd.conf
Line 65:
Line 60: %{__python} setup.py install -O1 --skip-build --root "%{buildroot}"
Line 61: install -Dp contrib/momd.init "%{buildroot}"/%{_initrddir}/momd
Line 62:
Line 63: cp
"%{buildroot}"/%{_defaultdocdir}/%{name}/examples/mom-balloon+ksm.conf \
Line 64: "%{buildroot}"/%{_sysconfdir}/momd.conf
this should be installed in automake
Line 65:
Line 66: # Correct the installed location of documentation files
Line 67: make %{?_smp_mflags} install DESTDIR="%{buildroot}"
Line 68: cp COPYING README "%{buildroot}"%{_defaultdocdir}/%{package_name}
Line 64: "%{buildroot}"/%{_sysconfdir}/momd.conf
Line 65:
Line 66: # Correct the installed location of documentation files
Line 67: make %{?_smp_mflags} install DESTDIR="%{buildroot}"
Line 68: cp COPYING README "%{buildroot}"%{_defaultdocdir}/%{package_name}
this is %doc
Line 69: mv "%{buildroot}"%{_defaultdocdir}/%{package_name} \
Line 70: "%{buildroot}"%{_defaultdocdir}/%{package_name}-%{version}
Line 71:
Line 72: %check
--
To view, visit http://gerrit.ovirt.org/22874
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4337150f58cd7d9b3a04a12a3afa9acd8a826a22
Gerrit-PatchSet: 6
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
