Alon Bar-Lev has posted comments on this change. Change subject: Change versioning schema and fix tarball ......................................................................
Patch Set 7: (2 comments) .................................................... File configure.ac Line 6: define([VERSION_MINOR], [3]) Line 7: define([VERSION_FIX], [2]) Line 8: define([VERSION_NUMBER], VERSION_MAJOR[.]VERSION_MINOR[.]VERSION_FIX) Line 9: define([VERSION_SUFFIX], [_master]) Line 10: yes, each (target) release (tag) is explicitly specified within sources. while pre-releases have suffix such as _master, _beta[X], _rc[X]. Line 11: AC_INIT([mom], VERSION_NUMBER[]VERSION_SUFFIX, [[email protected]]) Line 12: PACKAGE_RPM_VERSION="VERSION_NUMBER" Line 13: PACKAGE_RPM_RELEASE="3.20.$(echo VERSION_SUFFIX | sed 's/^_//')" Line 14: PACKAGE_NAME="mom" .................................................... File mom.spec.in Line 62: "%{buildroot}"/%{_sysconfdir}/momd.conf Line 63: Line 64: # Correct the installed location of documentation files Line 65: mv "%{buildroot}"%{_defaultdocdir}/%{package_name} \ Line 66: "%{buildroot}"%{_defaultdocdir}/%{package_name}-%{version} this is because you are using setuptools, right? isn't there is a way to enforce docdir for setuptools? Line 67: Line 68: %check Line 69: nosetests tests/*.py Line 70: -- To view, visit http://gerrit.ovirt.org/22874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4337150f58cd7d9b3a04a12a3afa9acd8a826a22 Gerrit-PatchSet: 7 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
