Allon Mureinik has posted comments on this change. Change subject: core: findbugs: Organize equals(Object) overrides ......................................................................
Patch Set 2: (1 comment) .................................................... File backend/manager/modules/bll/exclude-filters.xml Line 144: <Match> Line 145: <Class name="org.ovirt.engine.core.bll.scheduling.policyunits.NetworkPolicyUnit" /> Line 146: <Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/> Line 147: </Match> Line 148: Nice one! I don't want to cause a regression in our FindBugs stats, so I'll leave this here in the meanwhile. If the patch you referenced is merged beforehand, I'll remove it. If not, I'll remove it in a separate patch. Thanks for the input! Line 149: <Match> Line 150: <Class name="org.ovirt.engine.core.bll.utils.GlusterUtil" /> Line 151: <Or> Line 152: <Method name="getPeers" params="java.lang.String,java.lang.String,java.lang.String" /> -- To view, visit http://gerrit.ovirt.org/22964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3384d0c85f3c8ba91e25b584659e5e5f4617acb4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
