Moti Asayag has posted comments on this change.
Change subject: core: findbugs: Organize equals(Object) overrides
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ExtendedVmDynamic.java
Line 38: return false;
Line 39: }
Line 40:
Line 41: ExtendedVmDynamic other = (ExtendedVmDynamic) obj;
Line 42: return ObjectUtils.objectsEqual(host, other.host);
since this is the vdsbroker, you should be able to use
java.util.Objects.equals()
Line 43: }
Line 44:
Line 45: @Override
Line 46: public int hashCode() {
Line 44:
Line 45: @Override
Line 46: public int hashCode() {
Line 47: int result = super.hashCode();
Line 48: result = 31 * result + (host != null ? host.hashCode() : 0);
this can be replaced by java.util.Objects.hashCode(host)
Line 49: return result;
Line 50: }
--
To view, visit http://gerrit.ovirt.org/22964
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3384d0c85f3c8ba91e25b584659e5e5f4617acb4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
