Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: rollback legacy sysconfig ......................................................................
Patch Set 3: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/legacy/config.py Line 185: ) as f: Line 186: f.write( Line 187: self._backup, Line 188: ) Line 189: f.truncate() about truncate, I'll remove it. It's useful only if the file was opened r+, it's an unneeded precaution here. about preserving mask, the file already exists and it's mask won't be altered by write no? Line 190: Line 191: @plugin.event( Line 192: stage=plugin.Stages.STAGE_CLOSEUP, Line 193: condition=lambda self: self.environment[ -- To view, visit http://gerrit.ovirt.org/23071 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9e4a90a7e0e47aeb88a938fedb4f2088d533a70 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
