Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: rollback legacy sysconfig ......................................................................
Patch Set 2: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/legacy/config.py Line 182: if ( Line 183: self._backup is not None and Line 184: os.path.exists(self._backup) Line 185: ): Line 186: if self.environment[otopicons.BaseEnv.ERROR]: Wouldn't there be ERROR also if it's during closeup, after transaction finished? suppose e.g. that httpd restart failed. I agree we don't need to make it complex - but it might be easy, didn't check Line 187: os.rename( Line 188: self._backup, Line 189: osetupcons.FileLocations.LEGACY_OVIRT_ENGINE_SYSCONFIG Line 190: ) -- To view, visit http://gerrit.ovirt.org/23071 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9e4a90a7e0e47aeb88a938fedb4f2088d533a70 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
