Piotr Kliczewski has posted comments on this change.

Change subject: packaging: Jsonrpc packages deployment
......................................................................


Patch Set 1:

(2 comments)

I was requested to install those packages optionally depending on user choice.

As we discussed following changes are only for testing.

....................................................
File src/plugins/ovirt-host-deploy/vdsm-json/packages.py
Line 72:                 _(
Line 73:                     'Cannot locate vdsm-yajsonrpc package, '
Line 74:                     'possible cause is incorrect channels'
Line 75:                 )
Line 76:             )
Sure. Will update offline packager and will have one query.
Line 77:         self._enabled = True
Line 78: 
Line 79:     @plugin.event(
Line 80:         stage=plugin.Stages.STAGE_PACKAGES,


Line 80:         stage=plugin.Stages.STAGE_PACKAGES,
Line 81:         condition=lambda self: self._enabled,
Line 82:     )
Line 83:     def _packages(self):
Line 84:         self.packager.installUpdate(('vdsm-jsonrpc', 'vdsm-yajsonrpc'))
Both packages are developed in that way that are not dependent on one another 
so that is way we have both here.
Line 85: 
Line 86:     @plugin.event(
Line 87:         stage=plugin.Stages.STAGE_CLOSEUP,
Line 88:         condition=lambda self: (


-- 
To view, visit http://gerrit.ovirt.org/23089
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b690891cd0cae7e77cb188b7d7e6262cb2ef760
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to