Alon Bar-Lev has posted comments on this change. Change subject: packaging: Jsonrpc packages deployment ......................................................................
Patch Set 2: (2 comments) you need to update the spec of the offline as well, adding the jsonrpc as dependency http://gerrit.ovirt.org/#/c/23089/2/src/plugins/ovirt-host-deploy/vdsm/packages_json.py File src/plugins/ovirt-host-deploy/vdsm/packages_json.py: Line 60: ), Line 61: ) Line 62: def _validation(self): Line 63: if not self.packager.queryPackages(patterns=('vdsm-jsonrpc', Line 64: 'vdsm-yajsonrpc',)): do not draw code, indent using single indentation. if not self.packager.queryPackages( patterns=( 'vdsm-jsonrpc', 'vdsm-yajsonrpc', ) ): but it should be enough to query one. Line 65: raise RuntimeError( Line 66: _( Line 67: 'Cannot locate jsonrpc packages, ' Line 68: 'possible cause is incorrect channels' Line 74: stage=plugin.Stages.STAGE_PACKAGES, Line 75: condition=lambda self: self._enabled, Line 76: ) Line 77: def _packages(self): Line 78: self.packager.installUpdate(('vdsm-jsonrpc', 'vdsm-yajsonrpc')) still waiting to understand why we need both and there is no dependency. Line 79: Line 80: @plugin.event( Line 81: stage=plugin.Stages.STAGE_CLOSEUP, Line 82: condition=lambda self: ( -- To view, visit http://gerrit.ovirt.org/23089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b690891cd0cae7e77cb188b7d7e6262cb2ef760 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
