Roy Golan has posted comments on this change.
Change subject: core: clean QueriesCommandBase.CreateRetuenValue
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java
Line 34: return new VdcQueryReturnValue();
nice. is inheritance a new java feature we missed? :)
can we generify the return value and remove the need to cast it?
say:
QueriesCommandBase<V extends VdsQueryReturnValue>
protected V createReturnValue()
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java
Line 57: protected VdcQueryReturnValue CreateReturnValue() {
naming: create and not Create
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SearchQueryTest.java
Line 420: new SearchQuery<SearchParameters>(new
SearchParameters()).CreateReturnValue() instanceof SearchReturnValue);
I dont see the point in testing something that always returns "new
SearchReturnValue()" - this specific case is not polymorphic, the test is done
on the base class that introduces this method. may be I'm missing something
--
To view, visit http://gerrit.ovirt.org/4181
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I921a81ed50cb29abe2c824fcbf026f18c9da357e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
