Roy Golan has posted comments on this change. Change subject: core: Clean QueriesCommandBase.CreateRetuenValue ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java Line 34: return new VdcQueryReturnValue(); thing is when you'r generic you can avoid the bug you just spotted and have clean and safe code. since as you mentioned we probably dont have such polymorphic use in our code, a SearchReturnValue in SearchQuery is sufficient than. Still a user can do that QueriesCommandBase q = new SearchQuery(..) (SearchReturnValue) q.returnValue -- To view, visit http://gerrit.ovirt.org/4181 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I921a81ed50cb29abe2c824fcbf026f18c9da357e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
