Alon Bar-Lev has posted comments on this change. Change subject: packaging: Jsonrpc packages deployment ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/23089/3/src/plugins/ovirt-host-deploy/vdsm/packages_json.py File src/plugins/ovirt-host-deploy/vdsm/packages_json.py: Line 75: ) Line 76: def _packages(self): Line 77: self.packager.installUpdate(('vdsm-jsonrpc',)) Line 78: Line 79: @plugin.event( > The only advantage that I have is to have below message in the audit logs i if there is no error, all success. anyway you can always look at debug log. this is not useful for user. Line 80: stage=plugin.Stages.STAGE_CLOSEUP, Line 81: condition=lambda self: ( Line 82: self._enabled and Line 83: not self.environment[ -- To view, visit http://gerrit.ovirt.org/23089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b690891cd0cae7e77cb188b7d7e6262cb2ef760 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
