Juan Hernandez has posted comments on this change. Change subject: dropped optional requirements on centos ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23245/1/jasperreports-server.spec File jasperreports-server.spec: Line 28: Requires: jboss-ejb-3.1-api Line 29: Requires: jboss-servlet-3.0-api Line 30: Requires: jboss-logging Line 31: Requires: jboss-interceptors-1.1-api Line 32: %endif I don't understand this. CentOS defines the "rhel" macro with value "6" so this means that we are actually requiring these packages in RHEL and CentOS, where they aren't available. These packages are only available in Fedora and in the packaging of Red Hat for JBoss EAP, so the resulting binary RPMs won't install correctly in RHEL or CentOS. The .spec doesn't create any link to the .jar files contained in those packages, and those packages contain API classes that should be provided by any application server. All in all I think that these "Requires" can be removed, unconditionally, as the required classes are provided by the "jboss-as" dependency. Even that "jboss-as" dependency can be removed, in my opinion, as we are just repackaging the Jasper .zip distribution, which is application server independent. Line 33: Line 34: %description Line 35: %{product_description} is a powerful, yet flexible and Line 36: lightweight reporting server. Generate, organize, secure, -- To view, visit http://gerrit.ovirt.org/23245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1db0cf3547de59e9f217296fd8e56afca25afb74 Gerrit-PatchSet: 1 Gerrit-Project: jasperreports-server-rpm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
