Sandro Bonazzola has posted comments on this change. Change subject: Dropped application server dependencies ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/23245/1/jasperreports-server.spec File jasperreports-server.spec: Line 21: Requires: postgresql-server >= 8.4.7 Line 22: Requires: postgresql-contrib >= 8.4.7 Line 23: Requires: jboss-as >= 7.1.1 Line 24: Line 25: # Optional deps that require JBoss EAP 6 rpms not available on CentOS: > Please remove this completely it's not needed. Done Line 26: %if 0%{?rhel} Line 27: Requires: jboss-annotations-1.1-api Line 28: Requires: jboss-ejb-3.1-api Line 29: Requires: jboss-servlet-3.0-api Line 28: Requires: jboss-ejb-3.1-api Line 29: Requires: jboss-servlet-3.0-api Line 30: Requires: jboss-logging Line 31: Requires: jboss-interceptors-1.1-api Line 32: %endif > I don't understand this. CentOS defines the "rhel" macro with value "6" so Done Line 33: Line 34: %description Line 35: %{product_description} is a powerful, yet flexible and Line 36: lightweight reporting server. Generate, organize, secure, -- To view, visit http://gerrit.ovirt.org/23245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1db0cf3547de59e9f217296fd8e56afca25afb74 Gerrit-PatchSet: 1 Gerrit-Project: jasperreports-server-rpm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
