Martin Peřina has posted comments on this change. Change subject: tools: Notification properties changes. ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/23080/5/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java: Line 148: if (value < 0) { Line 149: throw new NumberFormatException(); Line 150: } Line 151: } catch (NumberFormatException exception) { Line 152: throw new IllegalArgumentException( > Yes. So we have 2 use cases whereas we only give message about one. I disagree, IMO error message fits fine for both cases Line 153: String.format( Line 154: "'%s' must be a non negative integer.", Line 155: property)); Line 156: } -- To view, visit http://gerrit.ovirt.org/23080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5753ba2cad2de90a7f2d14bd4675edc1dd35045e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
