Piotr Kliczewski has posted comments on this change. Change subject: engine: host-deploy changes for jsonrpc integration ......................................................................
Patch Set 3: (1 comment) Alon. Not sure what you mean by firewall port open. The code is done it that way that when a user chooses to use json the port is changed to 4044 (json port) and all the logic works as it was. http://gerrit.ovirt.org/#/c/23090/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java: Line 1034: _iptables = _getIpTables(); Line 1035: _customizationConditions.add(CustomizationCondition.IPTABLES_OVERRIDE); Line 1036: } Line 1037: } Line 1038: Will remove. Line 1039: Line 1040: Line 1041: /** Line 1042: * Returns the installation status -- To view, visit http://gerrit.ovirt.org/23090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43df4d16d65cde6c4e225c093a2ce5d94783f43d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
