Piotr Kliczewski has posted comments on this change. Change subject: engine: host-deploy changes for jsonrpc integration ......................................................................
Patch Set 3: The change is not needed. At any point in time you will have only one port opened. There are two choices: 1. 54321 - xml 2. 4044 - json When json is chosen there will be both ports bound but only one will be open it the firewall. By taking this approach we do not need to add any additional logic and change IPTablesConfig as you pointed. -- To view, visit http://gerrit.ovirt.org/23090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43df4d16d65cde6c4e225c093a2ce5d94783f43d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
