Piotr Kliczewski has posted comments on this change. Change subject: engine: host-deploy changes for jsonrpc integration ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/23090/6/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java: Line 910: } Line 911: parameters.setOverrideFirewall((Boolean) model.getOverrideIpTables().getEntity()); Line 912: boolean protocol = (Boolean)model.getTransportProtocol().getEntity(); Line 913: if (protocol) { Line 914: host.setPort(4044); > Why hard coded 4044 port? This is the default port for json. UI changes are intended only to let people test jsonrpc integration. On the other hand vdsm management port is also hard coded in the UI. Line 915: } Line 916: parameters.setTransportProtocol(protocol); Line 917: parameters.setRebootAfterInstallation(isVirt); Line 918: parameters.setAuthMethod(model.getAuthenticationMethod()); -- To view, visit http://gerrit.ovirt.org/23090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43df4d16d65cde6c4e225c093a2ce5d94783f43d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
